refactor(cast): consolidate cast convert#12638
refactor(cast): consolidate cast convert#12638dipanshuhappy wants to merge 21 commits intofoundry-rs:masterfrom
Conversation
dipanshuhappy
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
…eat/consolidate-cast-convert
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
thank you will need to fix tests to move forward
Updated |
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
nice, ty, that's much cleaner. pending other reviewers as this is a breaking change and need consensus.
|
@dipanshuhappy appreciate the work ser |
There was a problem hiding this comment.
I don't think we should merge this as is as it is breaking. What I would suggest is shimming the existing commands to call convert <...> internally and displaying a "This command is deprecated and may be removed in the future, please use cast convert <...> instead" message.
I realize this ends up making the code a bit messy again, but I'd much prefer this to us pushing a breaking change for a very common set of commands in a non-major bump
Understood... Updating to that ASAP. |
onbjerg
changed the title
|
curious what the status is here? |
4 participants
Motivation
Resolves #12500
Solution
Create a new file
convert.rswhich encapsulates all the sub commands mentioned.PR Checklist
NOTE: This does break existing cli commands related to conversation. Refer to the issue to know more about the cli commands that will break.